Skip to content

Add AcceptOwnershipForwarder changeset implementation and tests#22148

Merged
george-dorin merged 5 commits intodevelopfrom
create-accept-ownership-changeset-forwarders
Apr 24, 2026
Merged

Add AcceptOwnershipForwarder changeset implementation and tests#22148
george-dorin merged 5 commits intodevelopfrom
create-accept-ownership-changeset-forwarders

Conversation

@george-dorin
Copy link
Copy Markdown
Contributor

@george-dorin george-dorin commented Apr 23, 2026

Adds a new changeset that directly calls acceptOwnership() on a KeystoneForwarder contract using the environment's deployer key, without going through MCMS.

@github-actions
Copy link
Copy Markdown
Contributor

👋 george-dorin, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 23, 2026

✅ No conflicts with other open PRs targeting develop

@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented Apr 23, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
Test_CRE_V2_EVM_LogTrigger_Invalid_Address_Regression The test failed without providing specific error details, indicating an unspecified failure in the test case. Logs ↗︎
Test_CRE_V2_EVM_LogTrigger_Invalid_Address_Regression/[v2]_EVM.LogTrigger_-_EOA_address_(not_a_contract)_fails_with_EOA_address The test failed because it did not find the expected base message indicating the error condition. Logs ↗︎
Test_CRE_V2_EVM_LogTrigger_Invalid_Address_Regression/[v2]_EVM.LogTrigger_-_EOA_address_(not_a_contract)_fails_with_another_EOA The test failed because an EOA address that is not a contract did not trigger the expected failure. Logs ↗︎

View Full Report ↗︎Docs

@george-dorin george-dorin enabled auto-merge April 23, 2026 11:59
@cl-sonarqube-production
Copy link
Copy Markdown

@george-dorin george-dorin added this pull request to the merge queue Apr 23, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 23, 2026
@george-dorin george-dorin added this pull request to the merge queue Apr 23, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 23, 2026
@george-dorin george-dorin added this pull request to the merge queue Apr 24, 2026
Merged via the queue into develop with commit ab31fc0 Apr 24, 2026
263 of 265 checks passed
@george-dorin george-dorin deleted the create-accept-ownership-changeset-forwarders branch April 24, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants